Update with example and ordering

This commit is contained in:
James Harris 2017-02-22 04:55:56 +00:00 committed by GitHub
parent 3d91c64e95
commit f4d7d79cd0

View File

@ -1,23 +1,40 @@
# Contributing # Contributing
## What do I check? ## What do I check?
### Comments ### Comments
- Comments in the transcribed code should match 1:1 with the - Comments in the transcribed code should match the scans exactly
respective image.
- This could involve creating a deliberate typo or removing/adding - This could involve creating a deliberate typo or removing/adding
an entire comment. an entire comment.
### Line breaks ### Line breaks
- Line breaks **with** `R0000` in column 1 should match 1:1. - Line breaks *with* `R0000` in column 1 should match the scans exactly.
- Line breaks **without** `R0000` in column 1 should contain only 1 - Line breaks *with**__out__* `R0000` in column 1 should contain only 1
or 2 blank lines in a row. or 2 blank lines in a row.
- Lines with `R0000` in column 1 do not count towards this.
- If there are more than 2 blank lines breaks, strip the extra - If there are more than 2 blank lines breaks, strip the extra
line breaks. line breaks.
- Lines with `R0000` in column 1 do not count towards this.
- In the source images, these were created by an unprinted digit - In the source images, these were created by an unprinted digit
in column 8. A 2 there forced a double space (single blank line) in column 8. A 2 there forced a double space (single blank line)
and a 3 forced a triple space (double blank line). Values 4-8 were and a 3 forced a triple space (double blank line). Values 4-8 were
defined but never used. Read more about it in [#159][7] defined but never used. Read more about it in [#159][7]
For example the following:
```plain
R0819 SUBROUTINE TO SKIP...
R0820
0821 LAMPTEST CS IMODES33
```
Should become:
```plain
R0819 SUBROUTINE TO SKIP...
R0820
0820 LAMPTEST CS IMODES33
```
## Formatting ## Formatting
GitHub, [AGC Assembly][4] for Sublime Text 3 and [Language AGC][5] GitHub, [AGC Assembly][4] for Sublime Text 3 and [Language AGC][5]
for Atom will ensure you're using the correct formatting for Atom will ensure you're using the correct formatting
@ -33,12 +50,12 @@ settings overrides to add to your user settings [here][6].
## Useful Extensions ## Useful Extensions
GitHub has syntax support for the AGC assembly language built-in. GitHub has syntax support for the AGC assembly language built-in.
Unfortunately your code editor will not. Luckily there is a language Unfortunately your code editor will not, however there are
extension that provides syntax highlighting for the following AGC language extensions that provides syntax highlighting for the
editors: following editors:
- [Visual Studio Code][3]
- [Sublime Text 3][4]
- [Atom][5] - [Atom][5]
- [Sublime Text 3][4]
- [Visual Studio Code][3]
[0]:https://github.com/chrislgarry/Apollo-11/pull/new/master [0]:https://github.com/chrislgarry/Apollo-11/pull/new/master
[1]:http://www.ibiblio.org/apollo/ScansForConversion/Luminary099/ [1]:http://www.ibiblio.org/apollo/ScansForConversion/Luminary099/